GridActions.js ➔ ??? - Code Metrics - bencripps/react-redux-grid - Measure and Improve Code Quality continuously with Scrutinizer

GridActions.js ➔ ??? B
last analyzed 2018-02-15 14:17 UTC

↳ Parent: src/actions/GridActions.js

Complexity

Conditions	1
Paths	16

Size

Total Lines

163

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	16
dl	0
loc	163
rs	8.2857
c	0
b	0
f	0
nop	1

1 Function

Rating	Name	Duplication	Size	Complexity
B	GridActions.js ➔ ... ➔ ???	0	158	4

How to fix Long Method

import {
    ERROR_OCCURRED,
    HIDE_HEADER,
    MOVE_NODE,
    RESIZE_COLUMNS,
    SET_COLUMNS,
    SET_DATA,
    SET_SORT_DIRECTION,
    SET_TREE_DATA_PARTIAL,
    SET_TREE_NODE_VISIBILITY,
    SORT_DATA,
    INSERT_ROW
} from '../constants/ActionTypes';

import { setLoaderState } from '../actions/plugins/loader/LoaderActions';

import { dismissEditor } from '../actions/plugins/editor/EditorActions';

import { keyGenerator } from '../util/keyGenerator';

import { treeToFlatList } from '../util/treeToFlatList';

import Api from '../util/api';

export const getAsyncData = ({
    stateKey, dataSource, type, showTreeRootNode, extraParams = {}
}) => {

    return (dispatch) => {

        dispatch(dismissEditor({ stateKey }));

        dispatch(
            setLoaderState({state: true, stateKey })
        );

        if (typeof dataSource === 'function') {

            // passing extraParams.parentId
            // to custom func so they can do partial
            // loading
            dataSource(extraParams).then((response) => {

                if (response && response.data) {

                    dispatch(
                        setLoaderState({ state: false, stateKey })
                    );

                    if (type !== 'tree') {

                        dispatch({
                            type: SET_DATA,
                            data: response.data,
                            total: response.total,
                            currentRecords: response.data,
                            success: true,
                            stateKey,
                            editMode: extraParams.editMode
                        });
                    }

                    else {
                        // upon the return of read
                        // response needs to clarify
                        // whether this is a partial update
                        dispatch(setTreeData({
                            data: response.data,
                            stateKey,
                            showTreeRootNode,
                            parentId: extraParams.parentId,
                            partial: response.partial,
                            editMode: extraParams.editMode,
                            total: response.total
                        }));
                    }

                    return;
                }

                if (response && !response.data) {
                    /* eslint-disable no-console */
                    console.warn(
                        `A response was recieved
                         but no data entry was found`
                    );
                    console.warn(
                        `Please see
                         https://github.com/bencripps/react-redux-grid
                         for documentation`
                    );
                    /* eslint-enable no-console */
                }

                dispatch(
                    setLoaderState({ state: false, stateKey })
                );

                dispatch({
                    type: ERROR_OCCURRED,
                    error: 'Unable to Retrieve Grid Data',
                    errorOccurred: true,
                    stateKey
                });

            });

        }

        else if (typeof dataSource === 'string') {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined

            if (type !== 'tree') {

                return Api({
                    route: dataSource,
                    method: 'GET'
                }).then((response) => {

                    if (response && response.data) {

                        dispatch({
                            type: SET_DATA,
                            data: response.data,
                            total: response.total,
                            currentRecords: response.data,
                            success: true,
                            stateKey,
                            editMode: extraParams.editMode
                        });

                    }

                    else {
                        dispatch({
                            type: ERROR_OCCURRED,
                            error: 'Unable to Retrieve Grid Data',
                            errorOccurred: true,
                            stateKey
                        });
                    }

                    dispatch(
                        setLoaderState({state: false, stateKey })
                    );
                });

            }

            return Api({
                route: dataSource,
                method: 'GET',
                queryStringParams: {
                    parentId: extraParams.parentId
                }
            }).then((response) => {

                if (response && response.data) {

                    // response needs to specify
                    // whether this is full or partial update
                    dispatch(setTreeData({
                        data: response.data,
                        stateKey,
                        showTreeRootNode,
                        partial: response.partial,
                        parentId: extraParams.parentId
                    }));

                }

                else {
                    dispatch({
                        type: ERROR_OCCURRED,
                        error: 'Unable to Retrieve Grid Data',
                        errorOccurred: true,
                        stateKey
                    });
                }

                dispatch(
                    setLoaderState({state: false, stateKey })
                );
            });

        }

    };
};

export const setColumns = ({ columns, stateKey, stateful }) => {

    let cols = columns;

    if (!cols[0].id) {
        cols = columns.map((col) => {
            col.id = keyGenerator(col.name, 'grid-column');
            return col;
        });
    }

    return { type: SET_COLUMNS, columns: cols, stateKey, stateful };
};

export const setSortDirection = ({
    columns, id, sortDirection, stateKey
}) => {

    let cols = columns;


    cols = columns.map((col) => {

        if (col.id === id) {
            col.sortDirection = sortDirection;
        }

        else {
            // to do: remove this if we want to build
            // up the sorts
            col.sortDirection = null;
        }

        return col;
    });

    return { type: SET_SORT_DIRECTION, columns: cols, stateKey };
};

export const doLocalSort = ({ data, stateKey }) => ({
    type: SORT_DATA, data, stateKey
});

export const doRemoteSort = ({
    dataSource, filterFields, pageIndex, pageSize, sortParams, stateKey
}) => {

    return (dispatch) => {

        dispatch(
            setLoaderState({state: true, stateKey })
        );


        if (typeof dataSource === 'function') {
            return dataSource(
                { pageIndex, pageSize },
                filterFields,
                sortParams
            ).then((response) => {

                if (response && response.data) {

                    dispatch({
                        type: SET_DATA,
                        data: response.data,
                        total: response.total,
                        currentRecords: response.data,
                        success: true,
                        stateKey
                    });

                }

                else {

                    if (response && !response.data) {
                        /* eslint-disable no-console */
                        console.warn(
                            `A response was recieved but no data
                             entry was found`
                        );
                        console.warn(
                            `Please see
                             https://github.com/bencripps/react-redux-grid
                             for documentation`
                        );
                        /* eslint-enable no-console */
                    }

                    dispatch({
                        type: ERROR_OCCURRED,
                        error: 'Unable to Retrieve Grid Data',
                        errorOccurred: true,
                        stateKey
                    });
                }

                dispatch(
                    setLoaderState({state: false, stateKey })
                );
            });

        }

        return Api({
            route: dataSource,
            method: 'POST',
            data: {
                pageIndex: pageIndex,
                pageSize: pageSize,
                sort: sortParams.sort
            }
        }).then((response) => {

            if (response && response.data) {

                dispatch({
                    type: SET_DATA,
                    data: response.data,
                    total: response.total,
                    currentRecords: response.data,
                    success: true
                });

            }

            else {
                dispatch({
                    type: ERROR_OCCURRED,
                    error: 'Unable to Retrieve Grid Data',
                    errorOccurred: true
                });
            }

            dispatch(
                setLoaderState({state: false, stateKey })
            );
        });

    };
};

export const setColumnVisibility = ({
    columns, column, isHidden, stateKey, stateful
}) => {
    const hidden = !isHidden;

    const columnsArr = columns.map((col) => {
        if (col.name === column.name) {
            col.hidden = hidden;
        }

        return col;
    });

    return { type: SET_COLUMNS, columns: columnsArr, stateKey, stateful };
};

export const resizeColumns = ({
    width, id, nextColumn, columns, stateKey, stateful
}) => {

    const cols = columns.map((col) => {

        if (col.id === id) {
            col.width = `${width}%`;
        }

        else if (col.id === nextColumn.id) {
            col.width = `${nextColumn.width}%`;
        }

        return col;

    });

    return {
        type: RESIZE_COLUMNS,
        stateKey,
        columns: cols,
        stateful
    };

};

export const setData = ({ data, stateKey, editMode }) => ({
    type: SET_DATA, data, stateKey, editMode
});

export const setTreeData = ({
    data, stateKey, showTreeRootNode, partial, parentId, editMode, total
}) => {

    // if this is a partial update to
    // a tree grid, dispatch separate action;
    if (partial) {
        return {
            type: SET_TREE_DATA_PARTIAL,
            data: data,
            stateKey,
            gridType: 'tree',
            showTreeRootNode,
            parentId,
            total
        };
    }

    let flat = treeToFlatList(data);

    // remove root node
    if (!showTreeRootNode) {
        flat = flat.shift();
    }

    return {
        type: SET_DATA,
        data: flat,
        stateKey,
        gridType: 'tree',
        treeData: data,
        editMode,
        total
    };
};

export const insertRow = ({
    stateKey, data, index = 0
}) => ({
    type: INSERT_ROW,
    stateKey,
    data,
    index
});

export const setTreeNodeVisibility = ({
    id, visible, stateKey, showTreeRootNode
}) => ({
    type: SET_TREE_NODE_VISIBILITY,
    id,
    visible,
    stateKey,
    showTreeRootNode
});

export const moveNode = ({
    stateKey, current, next, showTreeRootNode
}) => ({
    type: MOVE_NODE,
    stateKey,
    current,
    next,
    showTreeRootNode
});

export const setHeaderVisibility = ({ hidden, stateKey }) => ({
    type: HIDE_HEADER, headerHidden: hidden, stateKey
});


1		import {
2		ERROR_OCCURRED,
3		HIDE_HEADER,
4		MOVE_NODE,
5		RESIZE_COLUMNS,
6		SET_COLUMNS,
7		SET_DATA,
8		SET_SORT_DIRECTION,
9		SET_TREE_DATA_PARTIAL,
10		SET_TREE_NODE_VISIBILITY,
11		SORT_DATA,
12		INSERT_ROW
13		} from '../constants/ActionTypes';
14
15		import { setLoaderState } from '../actions/plugins/loader/LoaderActions';
16
17		import { dismissEditor } from '../actions/plugins/editor/EditorActions';
18
19		import { keyGenerator } from '../util/keyGenerator';
20
21		import { treeToFlatList } from '../util/treeToFlatList';
22
23		import Api from '../util/api';
24
25		export const getAsyncData = ({
26		stateKey, dataSource, type, showTreeRootNode, extraParams = {}
27		}) => {
28
29		return (dispatch) => {
30
31		dispatch(dismissEditor({ stateKey }));
32
33		dispatch(
34		setLoaderState({state: true, stateKey })
35		);
36
37		if (typeof dataSource === 'function') {
38
39		// passing extraParams.parentId
40		// to custom func so they can do partial
41		// loading
42		dataSource(extraParams).then((response) => {
43
44		if (response && response.data) {
45
46		dispatch(
47		setLoaderState({ state: false, stateKey })
48		);
49
50		if (type !== 'tree') {
51
52		dispatch({
53		type: SET_DATA,
54		data: response.data,
55		total: response.total,
56		currentRecords: response.data,
57		success: true,
58		stateKey,
59		editMode: extraParams.editMode
60		});
61		}
62
63		else {
64		// upon the return of read
65		// response needs to clarify
66		// whether this is a partial update
67		dispatch(setTreeData({
68		data: response.data,
69		stateKey,
70		showTreeRootNode,
71		parentId: extraParams.parentId,
72		partial: response.partial,
73		editMode: extraParams.editMode,
74		total: response.total
75		}));
76		}
77
78		return;
79		}
80
81		if (response && !response.data) {
82		/* eslint-disable no-console */
83		console.warn(
84		`A response was recieved
85		but no data entry was found`
86		);
87		console.warn(
88		`Please see
89		https://github.com/bencripps/react-redux-grid
90		for documentation`
91		);
92		/* eslint-enable no-console */
93		}
94
95		dispatch(
96		setLoaderState({ state: false, stateKey })
97		);
98
99		dispatch({
100		type: ERROR_OCCURRED,
101		error: 'Unable to Retrieve Grid Data',
102		errorOccurred: true,
103		stateKey
104		});
105
106		});
		0 ignored issues – show Best Practice introduced 2016-08-21 15:46 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
107		}
108
109		else if (typeof dataSource === 'string') {
		0 ignored issues – show Complexity Best Practice introduced 2016-08-21 15:46 UTC by Report Bug Copy Issue Report There is no return statement if `typeof dataSource === "string"` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
110
111		if (type !== 'tree') {
112
113		return Api({
114		route: dataSource,
115		method: 'GET'
116		}).then((response) => {
117
118		if (response && response.data) {
119
120		dispatch({
121		type: SET_DATA,
122		data: response.data,
123		total: response.total,
124		currentRecords: response.data,
125		success: true,
126		stateKey,
127		editMode: extraParams.editMode
128		});
129
130		}
131
132		else {
133		dispatch({
134		type: ERROR_OCCURRED,
135		error: 'Unable to Retrieve Grid Data',
136		errorOccurred: true,
137		stateKey
138		});
139		}
140
141		dispatch(
142		setLoaderState({state: false, stateKey })
143		);
144		});
145
146		}
147
148		return Api({
149		route: dataSource,
150		method: 'GET',
151		queryStringParams: {
152		parentId: extraParams.parentId
153		}
154		}).then((response) => {
155
156		if (response && response.data) {
157
158		// response needs to specify
159		// whether this is full or partial update
160		dispatch(setTreeData({
161		data: response.data,
162		stateKey,
163		showTreeRootNode,
164		partial: response.partial,
165		parentId: extraParams.parentId
166		}));
167
168		}
169
170		else {
171		dispatch({
172		type: ERROR_OCCURRED,
173		error: 'Unable to Retrieve Grid Data',
174		errorOccurred: true,
175		stateKey
176		});
177		}
178
179		dispatch(
180		setLoaderState({state: false, stateKey })
181		);
182		});
183
184		}
185
186		};
187		};
188
189		export const setColumns = ({ columns, stateKey, stateful }) => {
190
191		let cols = columns;
192
193		if (!cols[0].id) {
194		cols = columns.map((col) => {
195		col.id = keyGenerator(col.name, 'grid-column');
196		return col;
197		});
198		}
199
200		return { type: SET_COLUMNS, columns: cols, stateKey, stateful };
201		};
202
203		export const setSortDirection = ({
204		columns, id, sortDirection, stateKey
205		}) => {
206
207		let cols = columns;
		0 ignored issues – show Unused Code introduced 2016-09-08 18:04 UTC by Report Bug Copy Issue Report The assignment to variable `cols` seems to be never used. Consider removing it. Loading history...
208
209		cols = columns.map((col) => {
210
211		if (col.id === id) {
212		col.sortDirection = sortDirection;
213		}
214
215		else {
216		// to do: remove this if we want to build
217		// up the sorts
218		col.sortDirection = null;
219		}
220
221		return col;
222		});
223
224		return { type: SET_SORT_DIRECTION, columns: cols, stateKey };
225		};
226
227		export const doLocalSort = ({ data, stateKey }) => ({
228		type: SORT_DATA, data, stateKey
229		});
230
231		export const doRemoteSort = ({
232		dataSource, filterFields, pageIndex, pageSize, sortParams, stateKey
233		}) => {
234
235		return (dispatch) => {
236
237		dispatch(
238		setLoaderState({state: true, stateKey })
239		);
240	View Code Duplication
		0 ignored issues – show Duplication introduced 2016-12-05 08:30 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
241		if (typeof dataSource === 'function') {
242		return dataSource(
243		{ pageIndex, pageSize },
244		filterFields,
245		sortParams
246		).then((response) => {
247
248		if (response && response.data) {
249
250		dispatch({
251		type: SET_DATA,
252		data: response.data,
253		total: response.total,
254		currentRecords: response.data,
255		success: true,
256		stateKey
257		});
258
259		}
260
261		else {
262
263		if (response && !response.data) {
264		/* eslint-disable no-console */
265		console.warn(
266		`A response was recieved but no data
267		entry was found`
268		);
269		console.warn(
270		`Please see
271		https://github.com/bencripps/react-redux-grid
272		for documentation`
273		);
274		/* eslint-enable no-console */
275		}
276
277		dispatch({
278		type: ERROR_OCCURRED,
279		error: 'Unable to Retrieve Grid Data',
280		errorOccurred: true,
281		stateKey
282		});
283		}
284
285		dispatch(
286		setLoaderState({state: false, stateKey })
287		);
288		});
289
290		}
291
292		return Api({
293		route: dataSource,
294		method: 'POST',
295		data: {
296		pageIndex: pageIndex,
297		pageSize: pageSize,
298		sort: sortParams.sort
299		}
300		}).then((response) => {
301
302		if (response && response.data) {
303
304		dispatch({
305		type: SET_DATA,
306		data: response.data,
307		total: response.total,
308		currentRecords: response.data,
309		success: true
310		});
311
312		}
313
314		else {
315		dispatch({
316		type: ERROR_OCCURRED,
317		error: 'Unable to Retrieve Grid Data',
318		errorOccurred: true
319		});
320		}
321
322		dispatch(
323		setLoaderState({state: false, stateKey })
324		);
325		});
326
327		};
328		};
329
330		export const setColumnVisibility = ({
331		columns, column, isHidden, stateKey, stateful
332		}) => {
333		const hidden = !isHidden;
334
335		const columnsArr = columns.map((col) => {
336		if (col.name === column.name) {
337		col.hidden = hidden;
338		}
339
340		return col;
341		});
342
343		return { type: SET_COLUMNS, columns: columnsArr, stateKey, stateful };
344		};
345
346		export const resizeColumns = ({
347		width, id, nextColumn, columns, stateKey, stateful
348		}) => {
349
350		const cols = columns.map((col) => {
351
352		if (col.id === id) {
353		col.width = `${width}%`;
354		}
355
356		else if (col.id === nextColumn.id) {
357		col.width = `${nextColumn.width}%`;
358		}
359
360		return col;
361
362		});
363
364		return {
365		type: RESIZE_COLUMNS,
366		stateKey,
367		columns: cols,
368		stateful
369		};
370
371		};
372
373		export const setData = ({ data, stateKey, editMode }) => ({
374		type: SET_DATA, data, stateKey, editMode
375		});
376
377		export const setTreeData = ({
378		data, stateKey, showTreeRootNode, partial, parentId, editMode, total
379		}) => {
380
381		// if this is a partial update to
382		// a tree grid, dispatch separate action;
383		if (partial) {
384		return {
385		type: SET_TREE_DATA_PARTIAL,
386		data: data,
387		stateKey,
388		gridType: 'tree',
389		showTreeRootNode,
390		parentId,
391		total
392		};
393		}
394
395		let flat = treeToFlatList(data);
396
397		// remove root node
398		if (!showTreeRootNode) {
399		flat = flat.shift();
400		}
401
402		return {
403		type: SET_DATA,
404		data: flat,
405		stateKey,
406		gridType: 'tree',
407		treeData: data,
408		editMode,
409		total
410		};
411		};
412
413		export const insertRow = ({
414		stateKey, data, index = 0
415		}) => ({
416		type: INSERT_ROW,
417		stateKey,
418		data,
419		index
420		});
421
422		export const setTreeNodeVisibility = ({
423		id, visible, stateKey, showTreeRootNode
424		}) => ({
425		type: SET_TREE_NODE_VISIBILITY,
426		id,
427		visible,
428		stateKey,
429		showTreeRootNode
430		});
431
432		export const moveNode = ({
433		stateKey, current, next, showTreeRootNode
434		}) => ({
435		type: MOVE_NODE,
436		stateKey,
437		current,
438		next,
439		showTreeRootNode
440		});
441
442		export const setHeaderVisibility = ({ hidden, stateKey }) => ({
443		type: HIDE_HEADER, headerHidden: hidden, stateKey
444		});
445

bencripps / react-redux-grid

GitHub Access Token became invalid

GridActions.js ➔ ??? B last analyzed 2018-02-15 14:17 UTC

Complexity

Size

Duplication

Importance

1 Function

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

GridActions.js ➔ ??? B
last analyzed 2018-02-15 14:17 UTC